Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IREE to 3.2.0rc20250129 and disable t5 sharktank-data-dependent tests #918

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Feb 5, 2025

github-actions bot and others added 3 commits January 29, 2025 16:10
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@renxida renxida requested a review from ScottTodd February 5, 2025 19:00
@renxida renxida marked this pull request as ready for review February 5, 2025 19:00
@renxida
Copy link
Contributor Author

renxida commented Feb 5, 2025

Feel free to click merge if this passes CI - sharktank / Data-dependent Tests

@sogartar
Copy link
Contributor

sogartar commented Feb 5, 2025

Does these test hang with IREE 3.2.0rc20250120 as well?
In general, I think we should move most of these tests to nightly.

@sogartar
Copy link
Contributor

sogartar commented Feb 5, 2025

I though that the bump revert #887 fixed the hangs.

@ScottTodd
Copy link
Member

Yeah, this PR could be included with a version update PR instead of on its own. The test does not hang on the currently pinned version.

@renxida
Copy link
Contributor Author

renxida commented Feb 5, 2025

Merged integrates/iree to retest, but now i'm getting

Error: No space left on device

going to wait until runners back up

requirements-iree-pinned.txt Outdated Show resolved Hide resolved
requirements-iree-pinned.txt Outdated Show resolved Hide resolved
@renxida renxida changed the title Temporarily skip t5 data dependent tests to unblock CI as I figure out how to add things one by one Update IREE to 3.2.0rc20250129 and disable t5 tests Feb 6, 2025
@ScottTodd
Copy link
Member

Thanks! Hope the CI looks good here 🤞

@renxida renxida changed the title Update IREE to 3.2.0rc20250129 and disable t5 tests Update IREE to 3.2.0rc20250129 and disable t5 data-dependent tests Feb 6, 2025
@renxida renxida changed the title Update IREE to 3.2.0rc20250129 and disable t5 data-dependent tests Update IREE to 3.2.0rc20250129 and disable t5 sharktank-data-dependent tests Feb 6, 2025
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the remaining test failures are flakes that I've seen on main too.

@renxida renxida merged commit 04739c7 into nod-ai:main Feb 7, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants